Skip to content

test: trim and parametrize low-value tests - #346

Merged
kentoku24 merged 3 commits into
mainfrom
test-trim-audit
Sep 12, 2026
Merged

kentoku24 merged 3 commits into
mainfrom
test-trim-audit

Conversation

@kentoku24

@kentoku24 kentoku24 commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner

要旨 (plan .omo/plans/test-trim-audit.md)

  • A群(即削除可)+B群(パラメタ集約)を振る舞い保証を落とさず削減する手順を実行
  • Todos 1-10 全完了: 安全削除(a)/Traceability6件削除+代替ゲート/Workflow8件parse置換/docs-meta維持/Discord集約/コマンド登録1本化/Source系集約/Runner系集約/GitHub・repair・storage集約/migrate切離し(_firestore_fakes.py新設)
  • レビュー指摘対応2件追加: stale manifest修正 (371c083)、nits修正 (6d65000: manifest重複除去/comic-days matrix/BOM統一/YAML自己テスト/manifestガード-test_acceptance_manifest.py/repair --backup-path)

証跡

  • discover 399 tests OK (.venv): python -m unittest discover -s tests -p 'test_*.py' green
  • run_mocked_acceptance 104 OK: python -m manga_watch.run_mocked_acceptance exit 0
  • manifest 53 paths全解決 (新規 tests/test_acceptance_manifest.py でCI保証)
  • 変更: tests/ 34ファイル + manga_watch/ 2ファイル (base.py: BOM除去統一、repair_mojibake.py: 注釈緩和+--backup-path)

Must-NOT-Have遵守

  • .github/workflows/*.yml 内容無変更
  • README/doc文言無変更 (TCキー・layer不変)
  • contract 5件・benchmark exact-set不変

レビュー観点

  • 5-lane review (Goal/QA/Quality/Security/Context) 全PASS。ブロッカーなし

@kentoku24
kentoku24 merged commit e561485 into main Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant